Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setFeatureState with string ids #7986

Closed
lanlugar opened this issue Mar 4, 2019 · 2 comments
Closed

Enable setFeatureState with string ids #7986

lanlugar opened this issue Mar 4, 2019 · 2 comments

Comments

@lanlugar
Copy link

lanlugar commented Mar 4, 2019

Motivation

I have want to setFeatureState of wfs layers gotten directly from mapbox, i am using the name of the feature to set the id, so i can easily reference the layer, however mapbox setFeatureState apparently doesn't work with string ids

Design Alternatives

Design

Mock-Up

Concepts

Implementation

@ryanhamley
Copy link
Contributor

ryanhamley commented Mar 4, 2019

Feature IDs such as those provided to setFeatureState can be a string, but the string has to be directly convertible to a base ten number. So '1234' is a valid feature ID but 'myID' or a hex number that includes letters wouldn't be. This is a technical limitation of the current vector tile specification.

@davidgilbertson
Copy link

davidgilbertson commented Jun 20, 2019

"...can be a string, but the string has to be directly convertible to a base ten number. So '1234' is a valid feature ID but 'myID' or a hex number that includes letters wouldn't be. This is a technical limitation of the current vector tile specification"

It would be great to have that description in the setFeatureState description, as a note next to
image

As per #7632

I think it's caused many people many hours of head scratching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants