Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outline from fill layer #8423

Closed
simonrp84 opened this issue Jul 2, 2019 · 4 comments
Closed

Remove outline from fill layer #8423

simonrp84 opened this issue Jul 2, 2019 · 4 comments

Comments

@simonrp84
Copy link

simonrp84 commented Jul 2, 2019

Hello,
I am using mapbox GL JS (v1.1.0) to display a series of GeoJSON polygon / fill objects. However, these exhibit the known issue of rendering problems (#7023), as shown by the horizontal yellow line in the pic below.
Untitled

It seems to me that this is an issue with the outline, so I tried fiddling with fill-outline-color and that does indeed change the color of these erroneous lines but does not get rid of them.
Is there a way to adjust some of the other props of the outline? For example by setting the fill outline opacity or similar? I tried a few combinations and checked the docs but can't find anything that looks suitable.
This is, unfortunately, a bit of a showstopper so any ideas and suggestions would be most welcome.

[edit] I should add, I'm not in charge of the JSON objects that need to be displayed, so editing the JSON to be compliant with how Mapbox can draw them is, sadly, not an option.

@mourner
Copy link
Member

mourner commented Jul 2, 2019

Unfortunately I can't diagnose the issue because there's not enough information — you haven't filled out the bug report template, including a minimal live test case. It's hard to guess what's going on just seeing the screenshot.

@simonrp84
Copy link
Author

Hello,
This isn't meant to be a bug report (this bug has already been reported many times, see the issue #7023 that I link to) but a question about attempting to find a workaround.
This issue will occur with any of the test cases given in #7023, such as #3545. I'm just asking if there is a property, say fill-outline-opacity, that could negate this issue.

@mourner
Copy link
Member

mourner commented Jul 3, 2019

@simonrp84 I don't think those artifacts are related to fill outline in any way. Generally you can disable the fill outline with fill-antialias: false.

@mourner mourner closed this as completed Jul 3, 2019
@simonrp84
Copy link
Author

Hi, just to add for anyone else that finds this: The fill-antialias: false option does fix the vast majority of the artefacts present when plotting GeoJSON polygons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants