Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port support for using icon-text-fit with vertical text #8806

Closed
ansis opened this issue Sep 25, 2019 · 0 comments · Fixed by #8835
Closed

port support for using icon-text-fit with vertical text #8806

ansis opened this issue Sep 25, 2019 · 0 comments · Fixed by #8835
Assignees
@ansis
Labels
api 📝 feature 🍏
Milestone
release-sangria

Comments

@ansis
Copy link
Contributor

ansis commented Sep 25, 2019

The remaining part of mapbox/mapbox-gl-native#15367 that hasn't been ported yet is support for icon-text-fit when combined with vertical text.

The two render tests this will fix are:

  • render-tests/text-writing-mode/point_label/cjk-variable-anchors-vertical-horizontal-mode-icon-text-fit
  • render-tests/text-writing-mode/point_label/mixed-multiline-vertical-horizontal-mode-icon-text-fit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansis ansis

Labels
api 📝 feature 🍏
Projects
None yet
Milestone
release-sangria
Development

Successfully merging a pull request may close this issue.

support icon-text-fit with vertical text mapbox/mapbox-gl-js
3 participants
@mourner @ansis @asheemmamoowala