Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"address" missing in model #13

Closed
cammace opened this issue Apr 12, 2016 · 4 comments
Closed

"address" missing in model #13

cammace opened this issue Apr 12, 2016 · 4 comments

Comments

@cammace
Copy link
Contributor

cammace commented Apr 12, 2016

sample White House feature json:

"id": "address.7626097581139850", "type": "Feature", "text": "Pennsylvania Ave NW", "place_name": "1600 Pennsylvania Ave NW, Washington, District of Columbia 20006, United States", "relevance": 0.99, "properties": {}, "center": [ -77.036543, 38.897702 ], "geometry": { "type": "Point", "coordinates": [ -77.036543, 38.897702 ] }, "address": "1600", "context": [ { "id": "neighborhood.7130293780113160", "text": "Franklin Mcpherson Square" }, { "id": "place.62020", "text": "Washington" }, { "id": "postcode.8344092665816130", "text": "20006" }, { "id": "region.6884744206035790", "text": "District of Columbia" }, { "id": "country.12862386939497690", "text": "United States", "short_code": "us" } ]

This includes address parameter and relevance which have no getter/setters.

@cammace
Copy link
Contributor Author

cammace commented Apr 12, 2016

scratch that it appears only address is missing in the SDK

@cammace cammace changed the title "address" and "relevance" missing in model "address" missing in model Apr 12, 2016
@zugaldia
Copy link
Member

@cammace As discussed, let's add a full test class to make sure we're doing well with all fields. Could you help building a sample query that includes all target fields?

@cammace
Copy link
Contributor Author

cammace commented Apr 12, 2016

Also appear to be missing "interpolated" within FeatureGeometry. It only shows up sometimes but is in the white house address query.

"geometry": { "type": "Point", "coordinates": [ -79.987504, 40.448817 ], "interpolated": true }

@zugaldia
Copy link
Member

I've added some tests in 9e811e9 that adds support for address and interpolated. They also change a bit the API. This should fix this problem, please reopen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants