Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: Not working for Languages with different Decimal Separator #39

Closed
pdiegmann opened this issue Apr 27, 2016 · 2 comments
Closed
Milestone

Comments

@pdiegmann
Copy link

Hi,

I just wanted to let you know, that the current version of your library is not working for many foreign devices, e.g. German, French, ..., on which a comma instead of a dot is used for decimal separation.
The line in question is probably MapboxDirections.java:262 resulting in
https://api.mapbox.com/v4/directions/mapbox.driving/-77.047237,38.892255;-77.019759,38.903568.json... for English / American devices and in https://api.mapbox.com/v4/directions/mapbox.driving/-77,047237,38,892255;-77,019759,38.903568.json... for e.g. German devices.
The latter request is failing, BTW.

@zugaldia
Copy link
Member

Good catch @pdiegmann. We just pushed a fix that should be available in the next SNAPSHOT if you want to try it tomorrow.

@pdiegmann
Copy link
Author

Great, fix! Thanks, @zugaldia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants