Enable camera animators to run without storing a reference #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs must be submitted under the terms of our Contributor License Agreement CLA.
Fixes: < Link to related issues that will be fixed by this pull request, if they exist >
Pull request checklist:
mapbox-maps-ios
changelog:<changelog>Updated
BasicCameraAnimatorso that it keeps animators alive while the animator is active.</changelog>
.Summary of changes
This PR stores a reference to an animator within
BasicCameraAnimator
and sets it to self while the animator is active. If the animation is paused or stopped, that property is set tonil
. It uses the approach from @macdrevx'sah/keep-alive
branch.This also updates the
CameraAnimatorsExample
so that the animators are no longer properties. I also tested out pausing and stopping the animators and different points.User impact (optional)