-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move OSRM-text-instructions to independent repo #82
Comments
For reference, we put the Swift port in a separate repository because iOS package managers (Carthage in particular, but also potentially SPM in the future) lack support for monorepos, preferring the modularity that comes with a one-to-one relationship between packages and repositories. |
@1ec5 thanks for pointing this out. On Android we don't have that restriction so it could be a folder within https://github.com/Project-OSRM/osrm-text-instructions. That way we wouldn't need to manually copy fixtures and translations, but I'll defer to @freenerd to decide the best location. |
I don't have a strong opinion. With swift we started "one repo per language and git submodules" and I'm good to keep it that way (via https://github.com/Project-OSRM/osrm-text-instructions.java). On the other hand, if you want to go the mono-repo approach and avoid git submodules I'm with that as well. |
@zugaldia @ericrwolfe should I hold off on moving OSRM over (and remove from 0.4.0 milestone) since we aren't sure if we still need it? |
I don't see moving this as a high priority item right now, so we should remove from 0.4.0 and we can revisit later. That being said, OSRM text instructions will remain around for the time being, so I'll defer to @zugaldia on the best end approach. |
Agreed on punting here if this isn't a priority right now. I'll assign it to myself and take care of it at a later milestone. |
At some point, we’ll need to bring this Java port of OSRM Text Instructions up to date with the JavaScript and Swift versions. To facilitate that merge, we’ll need to know roughly which commit to osrm-text-instructions the Java port and its text fixtures are currently based on. The code was originally ported in mapbox/mapbox-java#374, which would’ve been shortly before v0.2.0. |
Similar to Swift, https://github.com/Project-OSRM/osrm-text-instructions.swift the Java equivalent should live in its own repo for easier maintaining.
cc: @mapbox/navigation @freenerd
The text was updated successfully, but these errors were encountered: