-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using Transifex for abbreviations #1050
Comments
This sounds like a great first step IMO. |
The first step is happening in Project-OSRM/osrm-text-instructions#221. Along the way, @danpaz discovered that this SDK’s Brazilian Portuguese localization contained an entirely English abbreviations file, so that file is being omitted. |
Sent an announcement to Transifex’s Mapbox GL Native team (which is assigned to the iOS navigation SDK project there). OSRM Text Instructions
We’ve not only stopped managing abbreviation translations in Transifex, but we’ve also moved much of the abbreviation functionality to the server side, which was the impetus for this issue. |
We’ve been shoehorning the list of turn banner abbreviations into Transifex, with the assumption that translators would be more inclined to provide them directly in the same site as all the other localizable strings than to open a pull request here. But the Transifex interface isn’t well suited for tables – indeed, we have to convert from plist to an ad-hoc format just to be flexible about the number of abbreviations that a localization can provide. While we do document the format, the documentation is undiscoverable in Transifex’s interface. Translators have complained about the format in the past.
We could move the abbreviations into the OSRM Text Instructions repository and pull them into this SDK as part of the release process. Instead of pushing the table up to Transifex, we’d periodically encourage translators at Transifex to head over to GitHub to also provide abbreviations. (Google Documents would have a lower barrier to entry for translators, but I think we’d prefer GitHub-style version control.) If JSON would be too unfriendly to translators, OSRM Text Instructions could use CSV format and convert it to JSON at build time.
This would be a first step toward moving the abbreviation functionality to the server side. (Picture the Directions API providing a list of alternative forms for a word, and the navigation SDK choosing whichever one fits.) That would make it possible for the abbreviations to be based on the language of the region through which the route runs, rather than the user’s current system language. It would also make it much easier for the Android navigation SDK to abbreviate words in the turn banner.
/ref #1047 (comment)
/cc @mapbox/navigation @mapbox/guidance
The text was updated successfully, but these errors were encountered: