Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSRegularExpression issue #1325

Closed
ZZhaiDev opened this issue Apr 23, 2018 · 2 comments
Closed

NSRegularExpression issue #1325

ZZhaiDev opened this issue Apr 23, 2018 · 2 comments

Comments

@ZZhaiDev
Copy link

Hi, guys
The app is using navigation v0.14.1 or v0.15
I have a HongKong user reporting this "The app will show the navigation screen briefly (half a second) then the app crashed every time", but I can not reproduce this bug.

I can see the crash in my crashlytics:

Fatal Exception: NSInvalidArgumentException
*** -[NSRegularExpression enumerateMatchesInString:options:range:usingBlock:]: nil argument

also this:
snip20180423_26

Do you guys have any clue what is going on here?

@1ec5
Copy link
Contributor

1ec5 commented Apr 23, 2018

Unfortunately, that isn’t very much information to go off. This library doesn’t use NSRegularExpression, but MapboxDirections.swift does when cleaning up road names in the Directions API response. It would help a lot to know if a particular road is causing this crash. In OpenStreetMap, most Hong Kong street names are bilingual; perhaps some street name has characters that are causing the regular expression to crash for some reason.

The only other thing I can think of is that some of the road name abbreviation functionality may have indirectly used a regular expression. If that’s the case, try upgrading to v0.16.0 or newer, since #1169 removed that functionality in favor of road names preabbreviated by the Directions API.

@ZZhaiDev
Copy link
Author

@1ec5 Thanks, it solved the crash after i release the app with V0.16.2 SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants