Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hardcoded access token #20

Closed
cammace opened this issue Apr 24, 2017 · 5 comments
Closed

remove hardcoded access token #20

cammace opened this issue Apr 24, 2017 · 5 comments
Milestone

Comments

@cammace
Copy link
Contributor

cammace commented Apr 24, 2017

Before this repo goes public, the hardcoded access token should be removed from the testapp and the gradle script for creating developer_config.xml file added.

cc: @zugaldia @Guardiola31337

@zugaldia zugaldia modified the milestone: v0.1 Apr 24, 2017
@zugaldia
Copy link
Member

The token needs to be rotated too.

@zugaldia zugaldia mentioned this issue Apr 24, 2017
5 tasks
@tobrun
Copy link
Member

tobrun commented Apr 25, 2017

This was copied from mapbox-demo, no actions needed there?

@zugaldia
Copy link
Member

Yes. It needs to be removed (and rotated) from the demo app repo too. Ticketed in mapbox/mapbox-android-demo#291.

@zugaldia
Copy link
Member

I've removed the token with c0d965c. We still need to bring the developer token plugin before being able to close this ticket.

@zugaldia
Copy link
Member

Fixed in #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants