Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kotlin extension functions to expose APIs on mapboxMap #508

Closed
tobrun opened this issue May 11, 2018 · 4 comments
Closed

Use kotlin extension functions to expose APIs on mapboxMap #508

tobrun opened this issue May 11, 2018 · 4 comments
Labels
archived Archived by Stale bot.

Comments

@tobrun
Copy link
Member

tobrun commented May 11, 2018

Kotlin extension functions allow to expose APIs on existing classes. The idea is to expose APIs of plugins directly on MapboxMap to create a real plugin system. This would allow for the following developer experience:

  • add maps gradle dep
  • add plugin 1 gradle dep
  • add plugin 2 gradle dep
  • integrate maps with all public api found on MapboxMap

cc @cammace @zugaldia

@cammace
Copy link
Contributor

cammace commented May 21, 2018

Watching the talk at Google IO about ktx, there might be another option which would remove the need to publish a second artifact for each plugin to support this functionality. See proposal KEEP-110 which adds annotations which you can easily slip into your existing library to make the APIs more friendly. Not sure if we want to hold out for this proposal to add ktx support but it is an option.

@tobrun
Copy link
Member Author

tobrun commented Oct 8, 2018

Some movement on Maps KTX is moving in #712 and #715

@stale
Copy link

stale bot commented Apr 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived by Stale bot. label Apr 6, 2019
@stale
Copy link

stale bot commented Apr 6, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived Archived by Stale bot.
Projects
None yet
Development

No branches or pull requests

2 participants