Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accuracy circle layer #79

Closed
cammace opened this issue Aug 9, 2017 · 3 comments
Closed

Accuracy circle layer #79

cammace opened this issue Aug 9, 2017 · 3 comments
Assignees
Labels
enhancement location-layer-plugin Issues that deal with the location layer module

Comments

@cammace
Copy link
Contributor

cammace commented Aug 9, 2017

mapbox/mapbox-gl-native#9426 looks to add support for circle pitch alignment in runtime styling thus unlocking the ability to simplify the logic for the accuracy ring and animate it.

We are currently using a fill layer since it lays flat even when the maps tilted but with this property unlocked it should become a circle layer. Technically all the layer really could become a circle layer but for the customizability available as far as using drawable for the location icon, I'm thinking they should remain symbol layers.

cc: @tobrun @zugaldia

@cammace cammace added enhancement location-layer-plugin Issues that deal with the location layer module labels Aug 9, 2017
@cammace cammace self-assigned this Aug 9, 2017
@cammace
Copy link
Contributor Author

cammace commented Aug 9, 2017

On second look, this doesn't seem to be in 5.1.2. Any chance we could pull in that PR into the 5.1 release branch so that we can use it here @tobrun?

@tobrun
Copy link
Member

tobrun commented Aug 9, 2017

circle pitch alignment should be available in a 5.2.0-SNAPSHOT, no plans of adding new features to patch releases.

@cammace cammace added the blocked When progress on something gets blocked label Aug 14, 2017
@tobrun tobrun removed the blocked When progress on something gets blocked label Nov 4, 2017
@tobrun
Copy link
Member

tobrun commented Nov 4, 2017

User report on this in #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement location-layer-plugin Issues that deal with the location layer module
Projects
None yet
Development

No branches or pull requests

2 participants