Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization plugin #2

Closed
1ec5 opened this issue May 17, 2017 · 2 comments
Closed

Localization plugin #2

1ec5 opened this issue May 17, 2017 · 2 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented May 17, 2017

How about a plugin that uses runtime styling to automatically localize map labels into the user’s preferred language? There’s already a robust implementation of this feature in Objective-C targeting the macOS SDK that’s entirely compatible with the iOS SDK:

https://github.com/mapbox/mapbox-gl-native/blob/cc1ea759a681cadcfd06fd7bdda79ca6deb38c62/platform/macos/app/MapDocument.m#L346-L393
https://github.com/mapbox/mapbox-gl-native/blob/cc1ea759a681cadcfd06fd7bdda79ca6deb38c62/platform/macos/app/MGLVectorSource+MBXAdditions.m

mapbox/mapbox-gl-native#7031 tracks folding that implementation into the iOS and macOS SDKs proper. In the meantime, the plugin could be useful for developers whose applications ship in multiple markets on the App Store.

mapbox/mapbox-plugins-android#36 is the equivalent on Android.

/cc @ericrwolfe @lukasmartinelli

@1ec5
Copy link
Contributor Author

1ec5 commented May 17, 2017

Previously mapbox/ios-sdk-examples#36.

@jmkiley
Copy link
Contributor

jmkiley commented Jul 28, 2017

Added to the Mapbox iOS SDK with mapbox/mapbox-gl-native#9582. Closing, but reopen if needed.

@jmkiley jmkiley closed this as completed Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants