Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to notify unsupported hardware configuration #11

Closed
zugaldia opened this issue Oct 20, 2018 · 5 comments
Closed

API to notify unsupported hardware configuration #11

zugaldia opened this issue Oct 20, 2018 · 5 comments
Assignees
Labels
Android Enhancement New feature or request nostale not reviewed by stalebot P1 Good to have

Comments

@zugaldia
Copy link
Member

zugaldia commented Oct 20, 2018

This is an enhancement request. Currently, when trying to load the SDK into a device that isn't supported, the app would crash with the following message:

kotlin.NotImplementedError: An operation is not implemented: Device does not support SNPE! Vision SDK does not work with this device yet.

Though this is expected and documented, we'd probably want to add a more graceful way to handle these situations. One possibility is providing an API method to detect if the device is supported, or an error callback so that developer can implement a recovery path.

@yunikkk yunikkk added the Enhancement New feature or request label Oct 23, 2018
@yunikkk
Copy link
Collaborator

yunikkk commented Oct 23, 2018

Sounds good, I think VisionManager.isDeviceSupported could do the trick.
@BenDenen wdyt?

@BenDenen
Copy link
Contributor

@yunikkk @zugaldia Actually now we have utils class SystemInfoUtils which is uded into our Teaster app - I guess we could just change the method name

@yunikkk
Copy link
Collaborator

yunikkk commented Oct 23, 2018

Discussed with @BenDenen - will move this class to Vision SDK from Vision Core and make it more convenient to use.

@yunikkk yunikkk assigned RingerJK and unassigned BenDenen Apr 26, 2019
@yunikkk
Copy link
Collaborator

yunikkk commented Apr 26, 2019

API that checks if board is supported is
SupportedSnapdragonBoards.isBoardSupported(SystemInfoUtils.getSnpeSupportedBoard()).

We still need to update documentation to show this API usage.

@yunikkk yunikkk added P1 Good to have Android labels May 2, 2019
@vladzima vladzima added the nostale not reviewed by stalebot label Sep 25, 2019
@yunikkk
Copy link
Collaborator

yunikkk commented Apr 23, 2020

Will close this ticket, seems its out of date.
To check if device is supported we have the following API now : SystemInfoUtils.isVisionSupported

@yunikkk yunikkk closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Enhancement New feature or request nostale not reviewed by stalebot P1 Good to have
Projects
None yet
Development

No branches or pull requests

5 participants