Legend controls #100
Legend controls #100
Conversation
…ons to hide legend div
…inja inheritances from base.html
akacarlyann
force-pushed
the
legend-additions
branch
from
cc2f57b
to
95f6081
Compare
|
The new Mapbox attribution icon takes up a ton of room, which makes the legend look out of place. Looking for suggestions on how to rearrange legend and other map info/controls!
|
|
Nice, that legend design looks great @akacarlyann! Huge improvement. 🙏
Lots of options here - what about putting both the attribution and legend at the bottom of the map, and move the attribution icon to the left of the legend? |
|
Thought heatmaps could benefit from a continuous legend titled using weight_property . Implementation is clunky atm and assumes evenly spaced colors/stops. |
|
Looks good as a starting point @akacarlyann. The hard part with Heatmaps is that the color is not a perfect representation of the values specified in the legend, since the kernel density calculation sums up all values in the specified heatmap-radius region to calculate the color. We could solve that by clustering & aggregating the underlying data, and choosing a heatmap-radius to match the cluster-radius, so that the kernel density calculation is close to an exact representation of the color shown on the screen. |
|
@ryanbaumann Got it. I think I'll roll back the heatmap legend for now and leave that for someone's future PR since it will be more involved. I'll try to get the variable-radius legend in this week and I'll let you know when it's ready for review! |
|
No rush here - but wanted to ask if this is ready for review @akacarlyann? |
|
@ryanbaumann Not quite yet. Happy to wrap up this week though if you're looking for something to review. |
|
No rush - we'll have more bandwidth here starting next week too. |
akacarlyann
force-pushed
the
legend-additions
branch
from
5c1b50c
to
73ccdb1
Compare
…to set legend colors
…ntiguous squares, line)
|
@akacarlyann the latest changes look great! Are you ready for a review? |
|
@ryanbaumann Really close! I have a couple moving parts - setting a default shape for legend keys in each viz type and supporting circular legend keys in the horizontal layout. Happy to take any comments now but I should have those last pieces done by Wed, I think! |
|
@ryanbaumann Ready for a review on this :) |
…halo color for legend header text, precision for rounding numeric legend values, and adds contiguous bar legend key shapes
akacarlyann
force-pushed
the
legend-additions
branch
from
b6b11a1
to
981e157
Compare
There was a problem hiding this comment.
@akacarlyann this is an incredible PR, what a huge improvement in understanding data from all of these legend options. No more HTML / CSS wizardry required. 🙏
|
🎉 |
Work in progress!
Leave for separate pr:
May leave these for map-collections pr: