Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up picnic_site? #147

Closed
nickidlugash opened this issue Dec 21, 2015 · 9 comments
Closed

Clean up picnic_site? #147

nickidlugash opened this issue Dec 21, 2015 · 9 comments
Assignees

Comments

@nickidlugash
Copy link

Picnic sites should be tagged tourism=picnic_site. We pull features with this tag into the Streets poi layer.

There are a small number tagged amenity=picnic_site and leisure=picnic_site. Can we look into cleaning these up? I think these should all be tourism=picnic_site.

@pratikyadav pratikyadav self-assigned this Dec 22, 2015
@pratikyadav
Copy link
Contributor

@nickidlugash
Based on tourism=picnic_site, it is incorrect to use amenity=picnic_site and leisure=picnic_site.

The number is not too high so one member from BLR can hit this easily. @jinalfoflia will be knocking this out 👊 (we can scale up if needed).

Next action-

  • @jinalfoflia to remove amenity=picnic_site and leisure=picnic_site, and add tourism=picnic_site
  • @jinalfoflia to post a OSM diary post once the task is completed.

cc- @planemad @maning

@planemad
Copy link
Contributor

@pratikyadav @jinalfoflia Before cleaning up, lets announce this on the diary as it will be a mechanized edit that will take just a couple of minutes. If any of the edits were less than a year old, lets also message the user with a link to the diary so that they have a heads up before we touch their work.

@jinalfoflia
Copy link

Before cleaning up, lets announce this on the diary as it will be a mechanized edit that will take just a couple of minutes. If any of the edits were less than a year old, lets also message the user with a link to the diary so that they have a heads up.

@planemad 👍 Will write a diary before jumping onto the task.

@jinalfoflia
Copy link

I have posted the diary with the above contents.

/cc @planemad @maning @pratikyadav

@jinalfoflia
Copy link

Today I worked on cleaning up the tags amenity=picnic_site & leisure=picnic_site and replaced them with tourism=picnic_site tag. Here are the changesets related to the changes made on OSM.

Changesets for amenity=picnic_site

Changeset for leisure=picnic_site

If an edit was made with-in a year, I have sent a message to the user, informing about the change I made to their edit. There were a total of 44 messages sent.

This was the message format

Subject: Re-tagging picnic sites with tourism=picnic_site tag

Hi,

I'll be changing the tag from amenity=picnic_site to tourism=picnic_site tag as per this wiki, to find more information on this you can refer this diary entry.

This is the node that I have changed the tag for - https://www.openstreetmap.org/node/3353080237/history

Thank you!

Best,

Jinal Foflia

Some pain points:

  • It is a good idea to send a message to user intimating them about the change, but the process becomes tedious after a point of time. Since this was small number it could be managed. For bigger edits it would be a great idea to have a way in which it can be communicated.

Statistics

I spent half a day doing this clean-up. A good amount of time was spent in communicating the users with the change made to their edits. These are the number of nodes added by me.

screenshot 2015-12-23 20 23 21

/cc @nickidlugash @planemad @pratikyadav @maning

@pratikyadav
Copy link
Contributor

This is awesome @jinalfoflia
Let's capture these stats on your diary too and close here.

@jinalfoflia
Copy link

I have captured the above stats in a new diary post.

No further actions here. Closing it!

/cc @pratikyadav @planemad @nickidlugash @maning

@planemad
Copy link
Contributor

💥

@nickidlugash
Copy link
Author

I'm late to the party, but this is awesome, @jinalfoflia! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants