Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outstanding Security Vulnerability via RC which is using an out of date INI version #535

Closed
martin-fogelman opened this issue Jan 5, 2021 · 6 comments

Comments

@martin-fogelman
Copy link

martin-fogelman commented Jan 5, 2021

Hi Folks,

Node-pre-gyp uses RC, which in turn is using an out of date ini version with a high severity prototype pollution vulnerability: https://app.snyk.io/vuln/SNYK-JS-INI-1048974

It looks like RC hasn't been updated in some time and it's already been a few weeks (granted there were holidays), so I'm escalating the issue here in case folks can help. See RC issue 120 and RC resolved but unmerged PR 121.

A quick review does seem to show that Dominic was responsive in the past re minimist? (See RC pull 114 and RC pull 115; cf. #493)

Thanks

@springmeyer
Copy link
Contributor

I think node-pre-gyp can likely get away without using RC in a future release. So I may just go that direction: https://github.com/mapbox/node-pre-gyp/tree/remove-rc

@jmz527
Copy link

jmz527 commented Jan 31, 2021

@springmeyer just checking in, any updates on this?

@springmeyer
Copy link
Contributor

Yes, node-pre-gyp upcoming v1.0.0 release will drop rc (#552) so this issue will be resolved

@motishani
Copy link

@springmeyer do you know when the new v1.0.0 will be released?

@springmeyer
Copy link
Contributor

@motishani an alpha is already available. Try doing:

npm install @mapbox/node-pre-gyp@1.0.0-alpha4 --save

@springmeyer
Copy link
Contributor

@mapbox/node-pre-gyp@1.0.0 is now released, which solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants