Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a Travis build for node-webkit 0.10.0-RC1 (based on Node.js v0.11.13) #308

Closed
wants to merge 3 commits into from

Conversation

Mithgol
Copy link
Contributor

@Mithgol Mithgol commented Jun 28, 2014

A newer node-webkit's version (v0.10.0-rc1) is based on Node.js v0.11.13; a support for the latter was introduced by #184.

This pull request adds a Travis CI build for that node-webkit's version.

It made necessary to (additionally) preinstall a couple of i386 packages (because of Chromium differences introduced in this new node-webkit's version, I presume).

Several changes in node-pre-gyp were necessary as well. (The corresponding pull requests are mapbox/node-pre-gyp#92 and mapbox/node-pre-gyp#93.)

@Mithgol
Copy link
Contributor Author

Mithgol commented Jun 28, 2014

@springmeyer

  • Please erase my experimental branch nw-unstable from this repository.
  • You may want to bring some (or all) of these changes to your travis-refactor branch as well.

@Mithgol Mithgol mentioned this pull request Jun 28, 2014
springmeyer pushed a commit that referenced this pull request Jun 29, 2014
@springmeyer
Copy link
Contributor

thanks, done in ec903c2

@springmeyer springmeyer deleted the nw-v0.10.0rc1 branch June 29, 2014 04:02
@dimsuz
Copy link

dimsuz commented Jun 29, 2014

@springmeyer notice, that although node-sqlite3 v2.2.4 has just been released, I was not able to build it for node-webkit v0.10.0-rc1, here's why:
nw_crosswalk.json from node-pre-gyp got updated by @Mithgol to support nw-v0.10.0-rc1, but those changes got only into node-pre-gyp v0.5.19, while freshly released node-sqlite3 v2.2.4 depends on node-pre-gyp v0.5.18.
After locally changing package.json to depend on node-pre-gyp v0.5.19 compilation went just fine!
Decided to inform you, just in case.

I hope you were not lost in all those version numbers above :)

@Mithgol
Copy link
Contributor Author

Mithgol commented Jun 30, 2014

@dimsuz That's because the aforementioned commit ec903c2 actually happened later than version 2.2.4 was “released”.

(Version 2.2.4 was introduced ≈20 hours earlier in the commit cb83565 which was called v0.2.4 by mistake and thus you might have missed it. By now that commit is almost exactly 2 days old already.)

In some sense even this version (2.2.4) is not “released” yet (for example, the latest npm package is still 2.2.3).

tl;dr   Version 2.2.4 and the master branch do not support node-webkit v0.10.0-rc1 yet, but the support is ready to be introduced in the next release.

@dimsuz
Copy link

dimsuz commented Jun 30, 2014

Ah, right! understood then. Main thing is that it is about to start working with nw, I already successfully require-ing it from my pet project. Thank you all! :)

@Mithgol Mithgol mentioned this pull request Jul 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants