Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OPTIONAL_ARGUMENT_FUNCTION #755

Closed
wants to merge 1 commit into from
Closed

Fix OPTIONAL_ARGUMENT_FUNCTION #755

wants to merge 1 commit into from

Conversation

fanatid
Copy link

@fanatid fanatid commented Dec 25, 2016

No description provided.

@springmeyer
Copy link
Contributor

Can you explain why this was/is needed?

@fanatid
Copy link
Author

fanatid commented Jun 23, 2018

I think it was done because rest of macros had this.
Right now, I'm not sure what was requirements for, but I believe that wrap any macros argument to parentheses is good practice.

@fanatid fanatid deleted the patch-2 branch June 23, 2018 15:39
@springmeyer
Copy link
Contributor

Thanks. I'll keep close as this will change with N-API: #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fanatid @springmeyer