-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mapillary object tiles not loading #36
Comments
@jinalfoflia looking into it. @gyllen we're getting CORS error inconsistently across different users while requesting vector tiles of the restrictions. Any tips on how to resolve this? |
Error observed with 10 concurrent users, and the tiles loaded very slow (30 seconds-5 minutes) after map load. Once this was reduced to 5 users, the error was no longer faced, so it seems like the Mapillary servers got overloaded. |
@planemad Can't really see any big loads coming in. Would need to check this again. I talked to some of you colleagues over the weekend a SOTMUS. Here is a first fix for you guys. First lets switch to the production API, to call it you need to register a new applicaiton on Mapillary. Login and go here https://www.mapillary.com/app/settings/developers then copy that client id in link below. Big change with these tiles is that they are no longer connected to an image. Its the actual object, so many detections can be merged into on object and it gets its own location. All of the properties in the link are optional so you request the ones you want. Here is a breakdown on what they mean.
Let me know how this works out for you and if you need some additional properties or tweaking of the current ones. |
@gyllen fantastic. Will give this a try tomorrow 🐳 |
@gyllen getting "Uncaught Error: Unimplemented type: 4" using that endpoint. Is the Does this look ok? Lines 154 to 163 in 6e4c40c
|
Its |
Also typo from my side its |
@gyllen 🙇 works! Couple of things:
|
@gyllen the tiles loaded much faster with the new endpoint. But we continue to face the same issues intermittently on the map, the tiles suddenly stop loading. cc @ajithranka |
I am getting a 504 error. The Mapillary detected signage overlay is not loading. It would be great to resume mapping if this is fixed. |
@planemad Are you still facing this issues. It looks like we were overloading our read/write servers ourself for a couple of hours (huge segmentation works) |
@gyllen looks smooth now 👍 is this something to expect in the coming days? |
@planemad No this should not be expected ;), and if you ever see it again please report (tuning the system before making it real live in production). For the array, it is expected I don't think vector-tiles allows me to send actual json as properties. The rect_key is referring to the the part in the actual image. However to show rectangles you should probably ask for them by requesting all for an image. In MapillaryJS you can enable to show rects with a config option, also in a near future we will enable zoom in regular images. |
All smooth now. |
@gyllen Do the detected objects have a unique key we can use for filtering? Right now we are highlighting a selected object by filtering on |
@ajashton Yes add key to the tile url and you will get an uniq object key. Don't count on it as staying there though, as new images gets into the area this key will update. |
Sometimes the detected restrictions from Mapillary fail to load, there are these errors in the console:
cc: @planemad
The text was updated successfully, but these errors were encountered: