Remove unnecessary FlushCache calls

rasterio · May 16, 2017 · d8b9e01 · d8b9e01
1 parent 127c40c
commit d8b9e01
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/rasterio/_base.pyx b/rasterio/_base.pyx
@@ -274,7 +274,6 @@ cdef class DatasetBase(object):
     def stop(self):
         """Ends the dataset's life cycle"""
         if self._hds != NULL:
-            GDALFlushCache(self._hds)
             GDALClose(self._hds)
         self._hds = NULL
         log.debug("Dataset %r has been stopped.", self)

diff --git a/rasterio/_io.pyx b/rasterio/_io.pyx
@@ -522,7 +522,6 @@ cdef class DatasetReaderBase(DatasetBase):
         cdef GDALDatasetH dataset = NULL
 
         dataset = self.handle()
-        GDALFlushCache(dataset)
 
         # Prepare the IO window.
         if window:
@@ -1048,6 +1047,15 @@ cdef class DatasetWriterBase(DatasetReaderBase):
         self.update_tags(ns='rio_creation_kwds', **kwds)
         self._closed = False
 
+    def stop(self):
+        """Ends the dataset's life cycle"""
+        if self._hds != NULL:
+            GDALFlushCache(self._hds)
+            GDALClose(self._hds)
+        self._hds = NULL
+        self._closed = True
+        log.debug("Dataset %r has been stopped.", self)
+
     def set_crs(self, crs):
         """Writes a coordinate reference system to the dataset."""
         cdef char *proj_c = NULL

diff --git a/rasterio/_warp.pyx b/rasterio/_warp.pyx
@@ -703,8 +703,5 @@ cdef class WarpedVRTReaderBase(DatasetReaderBase):
     def stop(self):
         """Ends the VRT's life cycle"""
         if self._hds != NULL:
-            GDALFlushCache(self._hds)
             GDALClose(self._hds)
         self._hds = NULL
-
-