Perform calculations on blocks determined by a working memory limit option #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Original tests are passing and it's working on some biggish datasets I have on my laptop. I'll merge this later today unless we spot any issues. |
added 2 commits
May 15, 2019 16:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1668
The gist: we have a new
--mem-limitoption which defaults to64(megabytes). For very large calculations, we divide the work into square-ish regions such that the calculation results of these regions are no larger than the memory limit. For example, to runrio calc "(asarray (read 1 1), (* (read 1 2) 1.1), (read 1 3))"(boosts the green band of an RGB image by 10%) on a 7000 x 7000 pixel 3-band uint8 dataset without chunking would require--mem-limit=148. With the default 64 MB memory limit, the work would be done in 4 chunks.