Skip to content
This repository has been archived by the owner on Jan 25, 2019. It is now read-only.

react should be peerDependancy #12

Closed
dpwrussell opened this issue Jan 15, 2016 · 2 comments
Closed

react should be peerDependancy #12

dpwrussell opened this issue Jan 15, 2016 · 2 comments

Comments

@dpwrussell
Copy link

As it stands, react-range depends on react which can introduce a different version of React and thus to:

Uncaught Error: Invariant Violation: Modal.render(): A valid ReactComponent must be returned. You may have returned undefined, an array or some other invalid object.

It can be fixed temporarily by deleting node_modules/react-range/node_modules/react. I think the standard way of handling this is to make it a peer dependancy.

@damienleroux
Copy link

I made a pull request: #20.

I'll be thankful to have it accepted please.

Thank you :)

@dasulit
Copy link

dasulit commented Jan 24, 2019

Mapbox is no longer maintaining react-range. For a current alternative, check out https://mapbox.github.io/mr-ui/#controlrange.

@dasulit dasulit closed this as completed Jan 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants