Strict option for cogeo validation

[pierotofy]

Hello ✋

I propose the addition of a "strict" flag to threat warnings as errors for the purposes of validation.

There are situations in which this might be desirable (eg. trying to determine whether a GeoTIFF is suited for streaming, overviews lacking are warnings, but affect performance significantly).

[vincentsarago]

thanks for the pr @pierotofy
I'm glad I'm not the only one wanting overview in COG by default :-)
ref: #79

strict seems a bit odd because the specification says overviews are optional, maybe something like --force-overviews might make more sense ?

[pierotofy]

I borrowed the "strict" term from compilers, where warnings do not preclude a program from being compiled or running properly, but I can rename it to something else if you want.

I thought strict was more generic since it doesn't look just at overviews, but all warnings.

[vincentsarago]

I thought strict was more generic since it doesn't look just at overviews, but all warnings.

@pierotofy good point. yeah --force-overviews doesn't really make sense then (except if we add the option per say into cog_validate). Still strict feels a bit strong because the warning here is more an opinion than a proper warning (from the specification POV)

[pierotofy]

Mm, warnings_as_errors ? fail_on_warn?

[vincentsarago]

@pierotofy sorry for being slow to catch up, I've changed my mind and --strict seems a reasonable option so let's move forward.

Could you please add a --strict option in the CLI and make sure to run black on the files you changed ?

[pierotofy]

No worries, life keeps all of us busy.

I've made the changes as indicated, let me know if turher modifications are needed 👍

[vincentsarago]

thanks @pierotofy
I'm sorry but could you please run black on the cli too ?
and if it's not too much to ask, could you add some tests too ?

[pierotofy]

Not very familiar with black, but I did run it on all files in the project (including cli).

# black .
All done! ✨ 🍰 ✨
16 files left unchanged.
#

I can add a test; do you have a fixture already made that doesn't have overviews?

[vincentsarago]

thanks @pierotofy I think I can take it from here ;-)

[pierotofy]

Thanks @vincentsarago !