New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building type for ./rs features #130
Comments
The parking handler right now really works for any polygons. What we need to do is
A generic polygon post-processing handler works as long as we don't want to do e.g. special case post-processing for buildings. Also for the zoom level generalization check #51 and #88. What you can do for now is
Or better give #88 a try and see if it works for you. |
@daniel-j-h I ran it as faux-parking per your suggestion above (I did not run the linked branch), and it threw this:
Indeed, I don't see that param being handed in. |
The robosat/robosat/features/parking.py Line 19 in b7f6ebf
from the callsite here robosat/robosat/tools/features.py Line 49 in b7f6ebf
Are you sure you didn't accidentally delete it or change something when removing the tile check? |
I may well have. Also using a several-days-old, cpu-specific image at this point. Lemme update and try again. |
@daniel-j-h Pulling the updates did the trick! Thanks! I'd definitely love to see the generic polygon handler though; I'll be trying any number of feature types that are neither parking nor buildings. |
Wish we can set |
@daniel-j-h How rs features should work with roads detection? I am blocked on the pipeline here. Could you advice please? |
You'd have to implement the featurization for roads first. I'm no longer with Mapbox or actively developing or maintaining this project; please talk to Mapbox folks if you have questions.
…On May 13, 2020 1:46:44 PM UTC, Grifel79 ***@***.***> wrote:
@daniel-j-h How rs features should work with roads detection? I am
blocked on the pipeline here. Could you advice please?
|
Currently the only supported option is
parking
, which is incompatible with inputs trained on buildings.Am I correct that this will require another well-thought-out postprocessing handler?
The text was updated successfully, but these errors were encountered: