Segfault when getRouteSpeeds called before loadCSVs

[danpat]

When you use the SpeedLookup module, if you call getRouteSpeeds before you call loadCSVs, a segfault is raised.

After some debugging, this was tracked down to the datamap variable being uninitialized here:

route-annotator/src/speed_lookup_bindings.cpp

Line 180 in 7338f74

void Execute() override { result_annotations = datamap->getValues(nodeIds); }

We shouldn't segfault here. Instead, the desired behaviour is to return an array containing the correct number of INVALID_SPEED values, similar to what happens when node pairs are not found (see

route-annotator/src/segment_speed_map.cpp

Line 94 in 7338f74

speeds[segment_index] = INVALID_SPEED;

)

Checklist to fix this:

• write a JS test that triggers the segfault
• write a JS test that verifies the correct number of INVALID_SPEED values are returned if loadCSVs hasn't been called but we call getRouteSpeeds
• update package.json with a new version (0.0.4 perhaps?)
• create CHANGELOG.md to capture this change
• merge PR to master
• tag the release
• publish binaries by pushing an empty commit with the words [publish binary] in the commit message (I use git commit --allow-empty -m '[publish binary]' && git push).
• npm publish new version to the npmjs.org repository

[danpat]

/cc @ghoshkaj