Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RadianDirection with UnitAngle #38

Closed
1ec5 opened this issue Jan 20, 2018 · 2 comments · Fixed by #143
Closed

Replace RadianDirection with UnitAngle #38

1ec5 opened this issue Jan 20, 2018 · 2 comments · Fixed by #143
Assignees
@azarovalex
Labels
backwards incompatible changes that break backwards compatibility of public API Core improvement Improvement for an existing feature.
Milestone
v2.0.0 (RC)

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 20, 2018

This library represents radians as a RadianDirection type alias. Instead, we can use the built-in Measurement struct in conjunction with UnitAngle to convert between degrees and radians.

/cc @frederoni @captainbarbosa
@1ec5 1ec5 added the improvement Improvement for an existing feature. label Jan 20, 2018
@1ec5
Copy link
Contributor Author

1ec5 commented Jan 20, 2018

Measurement is only available on iOS 10, macOS 10.12, tvOS 10, and watchOS 3, so this refactoring would require us to increase all the minimum deployment targets.

@1ec5 1ec5 mentioned this issue Dec 18, 2019
Closed
@1ec5 1ec5 added this to the v2.0.0 milestone Feb 22, 2021
@1ec5 1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Feb 22, 2021
@truburt truburt modified the milestones: v2.0.0, v2.0.0 (GA) Mar 5, 2021
@1ec5 1ec5 modified the milestones: v2.0.0 (GA), v2.0.0 (RC) Mar 5, 2021
@1ec5
Copy link
Contributor Author

1ec5 commented Apr 1, 2021

Measurement is only available on iOS 10, macOS 10.12, tvOS 10, and watchOS 3, so this refactoring would require us to increase all the minimum deployment targets.

#112 increased the minimum deployment target, so this issue is no longer blocked.

@truburt truburt added improvement Improvement for an existing feature. and removed improvement Improvement for an existing feature. labels Apr 2, 2021
@azarovalex azarovalex self-assigned this Apr 8, 2021
@azarovalex azarovalex mentioned this issue Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azarovalex azarovalex

Labels
backwards incompatible changes that break backwards compatibility of public API Core improvement Improvement for an existing feature.
Projects
None yet
Milestone
v2.0.0 (RC)
Development

Successfully merging a pull request may close this issue.

Use Measurement API instead of RadianDirection typealias mapbox/turf-swift
3 participants
@1ec5 @azarovalex @truburt