Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: CLI supporting raw filters json #13

Open
GretaCB opened this issue Aug 22, 2018 · 0 comments
Open

Idea: CLI supporting raw filters json #13

GretaCB opened this issue Aug 22, 2018 · 0 comments

Comments

@GretaCB
Copy link
Contributor

GretaCB commented Aug 22, 2018

Per @springmeyer 's thoughts:

The CLI currently expects a --style flag that reads a mbgl style that is then run through /lib/styleToFilters.js

I think it would be ideal to also:

  • Have the CLI accept an option like --filters that would be the JSON schema which new shaver.Filter expects (in place of --style)
  • Have this "Filters" JSON schema clearly documented in the readme so that it is obvious how to use shaver without needing to form up a full mbgl style.

This could be useful for testing and finding lurking parsing bugs.

refs

NAN_METHOD(Filters::New) {

@GretaCB GretaCB mentioned this issue Aug 22, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant