Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Wang tiles #112

Closed
singalen opened this issue Dec 26, 2021 · 4 comments
Closed

Implement Wang tiles #112

singalen opened this issue Dec 26, 2021 · 4 comments
Labels
Milestone

Comments

@singalen
Copy link
Contributor

singalen commented Dec 26, 2021

Because they are awesome.

I guess this crate: https://docs.rs/tiled-json-rs/0.2.6/tiled_json_rs/struct.WangSet.html (source repo is now deleted) can be used as a reference point.

@bjorn
Copy link
Member

bjorn commented Dec 27, 2021

I guess this crate: https://docs.rs/tiled-json-rs/0.2.6/tiled_json_rs/struct.WangSet.html (source repo is now deleted) can be used as a reference point.

Just note that the source just moved, see https://gitlab.com/flukejones/tiled-json-rs and this comment by its author. But it can definitely be a good reference point.

@bjorn bjorn added this to the 1.0.0 milestone Dec 27, 2021
@josebaMdeL
Copy link
Contributor

HI all, I have make an initial support for WangSets, but I'm new on GitHub, and programming in general and I don't know how bad/good are my changes. There also are some things about the organization of the code that I don't understand so I wanted to know how should I proceed. Thanks in advance!

@bjorn
Copy link
Member

bjorn commented Jun 13, 2022

@josebaMdeL Thank you so much for helping with this! To proceed, please open a pull request. You've already done so by mistake, so now would be the time to do it on purpose. :-) The pull request will be the best place where we can provide feedback on your patch and allows us to merge it.

Feel free to ask any questions on the pull request after opening it, or on Discord. We have a dedicated #rs-tiled channel on the Tiled Discord.

@josebaMdeL
Copy link
Contributor

Done! #226

@bjorn bjorn closed this as completed in 1a10faf Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants