Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket fill shift behaviour doesn't behave as documented #2883

Closed
mitchcurtis opened this issue Aug 9, 2020 · 3 comments
Closed

Bucket fill shift behaviour doesn't behave as documented #2883

mitchcurtis opened this issue Aug 9, 2020 · 3 comments
Assignees
Labels
bug Broken behavior.

Comments

@mitchcurtis
Copy link
Contributor

mitchcurtis commented Aug 9, 2020

https://doc.mapeditor.org/en/stable/manual/editing-tile-layers/#bucket-fill-tool says:

When holding Shift, the tool fills the currently selected area regardless of its contents.

But when I tried this out, it doesn't behave as documented. Pressing and holding shift does nothing; it's the release that turns it into a "greedy" fill. Once the fill type changes, pressing and holding shift reverts it back to the original type of fill, while releasing switches it to the other type again.

Version 1.4.2 on a MacBook Pro.

@bjorn bjorn added the bug Broken behavior. label Aug 9, 2020
@bjorn
Copy link
Member

bjorn commented Aug 9, 2020

This is quite strange behavior. Must be some regression. Thanks for reporting it!

@bjorn bjorn closed this as completed in bfa6cd1 Jan 13, 2021
@bjorn bjorn self-assigned this Jan 13, 2021
@bjorn
Copy link
Member

bjorn commented Jan 13, 2021

Thanks for creating this issue, now I finally remembered to look into this!

@mitchcurtis
Copy link
Contributor Author

Oh, modifiers in Qt... it's always difficult for me, especially auto-testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

2 participants