Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Select object on map" does not work in non-object layer properties #3207

Closed
Yanrishatum opened this issue Dec 13, 2021 · 2 comments
Closed
Assignees
Labels
bug Broken behavior.

Comments

@Yanrishatum
Copy link

Right now it's impossible to use "Select object on map" on layer properties that are not object layers. Confirmed on tile, group and image layers.

Reproduction:

  1. Create an object
  2. Create object reference property on the tile layer
  3. Click "Select object on map"
  4. Attempt to select an object

What happens: Currently active tool is activated
What is expected: Current tool is deactivated and user can select an object.

Tiled: 1.7.2, Win10.

@eishiya
Copy link
Contributor

eishiya commented Dec 14, 2021

I wonder if this is related to how you can't select and use the Select Objects tool when you're not on an Object Layer, despite its functionality being something that should by all rights work from any layer, since it'll take you to the correct layer anyway. Tiled is a little too context-sensitive.

@bjorn bjorn added the bug Broken behavior. label Dec 14, 2021
@bjorn bjorn self-assigned this Dec 14, 2021
@bjorn bjorn closed this as completed in 92dfa20 Dec 14, 2021
@bjorn
Copy link
Member

bjorn commented Dec 14, 2021

Yeah, this behavior was inherited from AbstractObjectTool, but there is no reason to disable the ObjectReferenceTool when the current layer is not an object layer. Thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior.
Projects
None yet
Development

No branches or pull requests

3 participants