Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Automapping rule map as Project rules file #3221

Closed
eishiya opened this issue Dec 23, 2021 · 2 comments
Closed

Allow setting Automapping rule map as Project rules file #3221

eishiya opened this issue Dec 23, 2021 · 2 comments
Assignees
Labels
feature It's a feature, not a bug.

Comments

@eishiya
Copy link
Contributor

eishiya commented Dec 23, 2021

For projects that only have a single automapping rules map file, creating a rules.txt that just lists that one map file feels like an unnecessary inconvenience, especially since rules list files can't be edited within Tiled.

Please allow setting a map file as the Automapping rules file for a Project directly. This should take the form of an alternate file type selectable in the browser, e.g. "Automapping Rule Maps (*.tmx, *.tmj, *.json)", so that the default option still only looks for TXT files.

On a related note, what's the proper terminology for these files? It seems to be the TXT files are "automapping rules files", while the maps are "automapping rule files", which is confusing.

@bjorn bjorn added the feature It's a feature, not a bug. label Dec 23, 2021
@bjorn bjorn self-assigned this Jan 21, 2022
@bjorn bjorn closed this as completed in 6c0f477 Jan 21, 2022
@bjorn
Copy link
Member

bjorn commented Jan 21, 2022

Now you can set a map file directly, and not only that, but the Automapping feature should now work with any map format, rather than being hardcoded to only supporting ".tmx" files. :-)

And, it works with a plain map file as well when using the TileMap.autoMap scripting function!

@eishiya
Copy link
Contributor Author

eishiya commented Jan 21, 2022

Oh, I had no idea only TMX was allowed. Good fix!

TileMap.autoMap(mapFile) could be useful for scripting conditional automapping, that could be interesting 👀 I could use that to implement #3014 as a script, since it sounds like the consensus there is leaning away from the approach that I would find useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature It's a feature, not a bug.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants