-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Classes Member properties do not export to Lua file #3315
Comments
Issue 1 is a duplicate of #3307, as the underlying problem was that Tiled wasn't copying these properties into the copy of the map that gets passed to the various exporters. It'll be fixed in 1.8.3. |
That is correct.
No, actually the issue is here, that @dennisfortin didn't set any of the members of that class, and the default values are not written out. For those that actually need the full classes written out, the plan was to make an export option for this, or to make it part of the "Resolve types and properties" export option. If there's nothing against the latter I can look into doing that as part of Tiled 1.8.3. |
Ah, good catch. In the screenshot, since the properties were black, I thought they were manually set. Do classes members not have a visual distinction between set and unset/default values? |
They do, but it's not graying out, instead the set members have their name displayed in bold. |
Ah. I think that's too subtle, I didn't notice it ): Bold tends to be harder to notice in dark themes. Is there a reason it's done differently for class members? It's not possible for a class member to be unset in both ways at once or to be set in one way but not in another, so I don't think the two different visualisations are necessary. |
Hello, seems that in the latest version of Tiled (1.10.2) the above issue is still there. |
Are you using the "resolve object types and properties" export setting? If your class is used as a custom property type, rather than as a class directly on some entity (Object, Tile, Layer, etc), those properties are currently not resolved even if that export setting is used, and this applies to all export types, not just Lua (see #3411). Edit: Just noticed this issue is still open. This means it has not been addressed yet. So, no wonder that it's still happening. |
@Immow Could it be that you're running in to the fact that, for compatibility reasons, I made the unfortunate mistake of renaming this property in Tiled 1.9, and it kept tripping people up for months. That's why I renamed it back in Tiled 1.10. |
Issue 1
The new RepeatX and RepeatY properties for image layers do not export to Lua files. The value is always set to "false" even when they are set to true in Tiled.
Steps
Issue 2
The members for new Custom Class properties do not export to Lua files. The property value is exported as an empty Lua table.
Steps
Example
When exported to a Lua file, these properties will look as follows:
The text was updated successfully, but these errors were encountered: