Crash when using camera_zoom #99
Comments
|
Fixed in 88044a2 |
Merged
mapedorr
added a commit
that referenced
this issue
Oct 27, 2023
* Fix node selection, pitch and stretch setup fix: #89 by using `get_pitch_scale` instead of defining a get method for the `pitch` property. fix: #80 by changing the way `popochiu_plugin.gd` selects the WalkToHelper and Baseline nodes. fix: part of #96 by not overriding the setup made in the project settings regarding those properties unless the game type is set to "Pixel". * Fix #79 and #81 Now deleting Popochiu objects directly in PopochiuRoom scene tree also updates the rows in the Room tab. * Fix: #88 and #99 upd: README and LEEME file with small icons and links to the currento supported Godot versions for Popochiu 2 and the Discord server. fix: Camera zoom was calling a typo method. upd: New audio stream players are created during runtime if the system runs out of them. * Fix in extra row creation when adding room objects fix: Selecting game display type working properly. fix: WalkToHelper or BaselineHelper were keeping selected when selecting another node. fea: Added support for assigning an emotion when calling `PopochiuCharacter.say(text: String, emotion: String)`. It also works for `queue_say()`. * Fix #82 The `graphic_interface` folder can be moved to `res://popochiu` without bugs. upd: remove all uses of `EditorInterface.edit_node()` by `PopochiuUtils.select_node()`. * upd: Replaced old `_now` suffix by `queue_` prefix Added res://popochiu/ (game project) to .gitignore in order to avoid conflicts on things related to the project each developer is working on. * Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen * fix: dialog option ID no longer writing backwards Removed not used connection and changed plugin version. Updated version name with alpha suffix. * Create release notes for Alpha 3 * Fix typo and update links in Fixes section
mapedorr
added a commit
that referenced
this issue
Oct 27, 2023
* Fix node selection, pitch and stretch setup fix: #89 by using `get_pitch_scale` instead of defining a get method for the `pitch` property. fix: #80 by changing the way `popochiu_plugin.gd` selects the WalkToHelper and Baseline nodes. fix: part of #96 by not overriding the setup made in the project settings regarding those properties unless the game type is set to "Pixel". * Fix #79 and #81 Now deleting Popochiu objects directly in PopochiuRoom scene tree also updates the rows in the Room tab. * Fix: #88 and #99 upd: README and LEEME file with small icons and links to the currento supported Godot versions for Popochiu 2 and the Discord server. fix: Camera zoom was calling a typo method. upd: New audio stream players are created during runtime if the system runs out of them. * Fix in extra row creation when adding room objects fix: Selecting game display type working properly. fix: WalkToHelper or BaselineHelper were keeping selected when selecting another node. fea: Added support for assigning an emotion when calling `PopochiuCharacter.say(text: String, emotion: String)`. It also works for `queue_say()`. * Fix #82 The `graphic_interface` folder can be moved to `res://popochiu` without bugs. upd: remove all uses of `EditorInterface.edit_node()` by `PopochiuUtils.select_node()`. * upd: Replaced old `_now` suffix by `queue_` prefix Added res://popochiu/ (game project) to .gitignore in order to avoid conflicts on things related to the project each developer is working on. * Change MOVING_ by LOOKING_ in PopochiuCharacter.FlipsWhen * fix: dialog option ID no longer writing backwards Removed not used connection and changed plugin version. Updated version name with alpha suffix. * Create release notes for Alpha 3 * Fix typo and update links in Fixes section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Zooming works but as soon as you try to zoom back to the original position it causes a crash.
Invalidcall. Nonexistent function 'isplaying_queue' in base Tween
Tried this a few ways both during conversations/sequences and by triggering by exiting/entering a region. I wanted to make sure that it still crashed even after I was sure the tween should have finished.
Does not log an error but does point here
func camera_zoom(target := Vector2.ONE, duration := 1.0) -> void:
if is_instance_valid(_tween) and _tween.isplaying_queue():
_tween.kill()
Godot 4.1.1
Popochiu v2.0.0
The text was updated successfully, but these errors were encountered: