Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Downloading VP9 or AV1 video and OPUS audio when available at 1080p (or lower) source #19

Closed
Aesis7271 opened this issue Jul 31, 2020 · 4 comments

Comments

@Aesis7271
Copy link

So far this wasn't an issue for me since I've always been using the manual link downloads, but the manual link downloads are now throttled since a few days while the one click download isn't, which is why I'm proposing this enhancement.
It would be nice to be able to get the higher quality codecs (when available) when the source video is 1080p (or lower) when using the one click download. The one click download only downloads AVC (x264) video and MP3 audio even when VP9 or AV1 video and OPUS audio is available. I tried editing the script by changing
x.mimeType.includes('video/mp4')
to
x.mimeType.includes('video/webm')
for both video and audio, and while the video is correctly downloaded in VP9, the audio is being downloaded in the lowest OPUS quality. This is (probably) because the script takes the first OPUS codec from the itag list , which is sorted in ascending order, and the highest quality OPUS audio is the highest ID from the list (in this case, itag=251).
My coding knowledge is rather limited so I'm not able to go much further by myself, but maybe the script can be made to take the highest itag from the audio and video list respectively (since this is also the case for video side, where the itags are in ascending order of AVC<VP9<AV1 within the same resolution and framerate), or to sort by descending order instead.
Note that the video is downloaded in VP9 when the source is >1080p (since such sources don't have AVC encoding)

@maple3142
Copy link
Owner

but the manual link downloads are now throttled since a few days while the one click download isn't

It can be sped up by using a multi-thread downloader such as IDM, aria2 or whatever.

I choose x264 on purpose because it is more widely supported across platforms and applications. If you want that, you can edit it yourself or use youtube-dl.

@Aesis7271
Copy link
Author

Aesis7271 commented Jul 31, 2020

It can be sped up by using a multi-thread downloader such as IDM, aria2 or whatever.

I don't think it has to do with mutithreading at all, it's the download behavior that changed, I was previously able to get 3MB/s per item, I'm now getting 2MB/burst (every 5-10 seconds) with nothing in between.

I'll see what I can do to edit it myself

@maple3142
Copy link
Owner

I don't think it has to do with mutithreading at all

It is. One click download is slow when I didn't implement multi-thread downloading, and it becomes much faster after.

@Aesis7271
Copy link
Author

Aesis7271 commented Jul 31, 2020

I don't think it has to do with mutithreading at all

It is. One click download is slow when I didn't implement multi-thread downloading, and it becomes much faster after.

So why were the links working fine just a few days ago? I haven't changed browsers nor updated my current one (chrome), the script version hasn't changed and the downloads just stopping for 10 seconds then downloading 2MB then stopping again doesn't add up to lack of multithreading.

EDIT: I tried out IDM, it's not able to reach the previous download speeds either, I'll boil it down to youtube changing how they serve video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants