Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all string to locale class #3621

Merged
merged 10 commits into from
Jan 28, 2024
Merged

Move all string to locale class #3621

merged 10 commits into from
Jan 28, 2024

Conversation

HarelM
Copy link
Member

@HarelM HarelM commented Jan 25, 2024

Launch Checklist

Related:

This moves all the strings to the same place and also aligns their names.
This is basically a refactoring, but also a breaking change, so it should be part of 4.0.
The changes in public API is for the cooperative gestures configuration when initializing the map.
I have updated the relevant example.

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c6484d) 87.02% compared to head (d72e8e7) 85.63%.

Files Patch % Lines
src/ui/handler/cooperative_gestures.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
- Coverage   87.02%   85.63%   -1.40%     
==========================================
  Files         240      240              
  Lines       32212    32211       -1     
  Branches     2112     2181      +69     
==========================================
- Hits        28032    27583     -449     
- Misses       3248     3606     +358     
- Partials      932     1022      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ui/map.ts Outdated Show resolved Hide resolved
@HarelM
Copy link
Member Author

HarelM commented Jan 27, 2024

@neodescis can I merge this? I've changed the type according to your input, although I think the member itself is always full due to the extend initialization, but it's not critical, anything is better than "any" from my point of view.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Bart Louwers <bart.louwers@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not try it out myself, but looks good.

@HarelM HarelM enabled auto-merge (squash) January 28, 2024 13:49
@HarelM HarelM merged commit a1ca906 into main Jan 28, 2024
15 checks passed
@HarelM HarelM deleted the improve-locale branch January 28, 2024 14:10
@neodescis
Copy link
Collaborator

@neodescis can I merge this? I've changed the type according to your input, although I think the member itself is always full due to the extend initialization, but it's not critical, anything is better than "any" from my point of view.

Sorry, I mostly don't look at these on the weekend unless I have some spare time. Next time I can approve in advance if you like! I think you're right about the extend() initialization though; sorry I missed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants