Add ClientOptions to be able to pass around client name and version

[ntadej]

Add ClientOptions to be able to pass around client name and version. The first client is Qt platform user agent setting. I can try to update other platforms that set user agent later.

The result example is

Vremenar/0.6.0 (macOS 12.4) MapLibreGL/9e31d615 (Qt 6.3.1)

Will investigate in a separate PR on how to override the git hash with a version when building a release build.

[rinigus]

This looks rather large. Let me know if you still want a review as you closed the PR.

[ntadej]

It was a mistake. Not sure what happened.

[wipfli]

I don't quite understand what the use case is for client option. This is not just Qt related, right?

In many places client option appears next to resource options. I wonder if we should put the information which is in client options into resource options?

[ntadej]

I don't quite understand what the use case is for client option. This is not just Qt related, right?

In many places client option appears next to resource options. I wonder if we should put the information which is in client options into resource options?

It is to set client metadata basically. For now Qt user agent is set based on that but I plan to update other http classes for other platforms witht that.

I did not want to put into resource options as that is specific to the resource used (so tiles settings).

[wipfli]

I reviewed half of the files up and including to platform/default. Please use the full varable names like resourceOptions instead of resourceOpts. Other than that, my main question is if this is a breaking change for iOS or Android users...

[wipfli]

And thanks for your work @ntadej :)

[ntadej]

Hi @wipfli, I cleaned-up the code a bit:

• do not use abbreviated variable names
• set defaults in mbgl::Map and mbgl::MapSnapshotter

Regarding iOS and Android. In iOS none of the headers were changed. In Android all interface should go through Java.

[wipfli]

Thanks for you work @ntadej. This looks good to me. I left one or two coding questions for my own education. The render tests on my ubuntu machine after running #350 (comment) resulted in only one failing test, which is render-tests/icon-text-fit/enlargen-both which already fails on main.

[rinigus]

I'll try to build it for SFOS as well.

[rinigus]

Scratch that SFOS build - our OBS is down and not sure when I can do it.

[wipfli]

What is SFOS and OBS?

[rinigus]

SFOS - Sailfish OS - mobile Linux distro
OBS - Open Build Service - set of servers that allows SFOS developers to build for a range of SFOS versions and architectures.

In the context of QMapLibreGL - SFOS is using ancient Qt (5.6) due to licensing changes introduced later. As we have some bits proprietary, company behind SFOS is reluctant to change. I am using QMapLibreGL for mapping app, hence my interest to make sure it works on older Qt as well :)

But looks like these changes are mainly on C++ part which should be fine as we have reasonably up to date gcc

[ntadej]

@rinigus, are there docker images with Sailfish OS? We may be able to setup some basic CI with them.

[rinigus]

@ntadej: there are some, but those are unofficial and I don't know how well they track SFOS releases. OBS has been a tool of choice for many of us. I'll have to look into docker SFOS images, but don't expect it soon - quite swamped right now.

[rinigus]

I managed to compile on for SFOS and it passed nicely. As I don't have time to review these large changes in any reasonable time and since @wipfli already did it, I will approve the changes on my side to avoid stalling PR

[rinigus]

As additional note: it is surprising that a relatively simple change in client options requires so many changes. I guess it is a shortcoming of the used library design

[ntadej]

Hi @roblabs, as we did not have time to discuss this one, I wonder if you have an opinion. I plan to implement this also for iOS and Android in a separate PR.