Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: adding annotations from a JSON API for Android #811

Closed
louwers opened this issue Feb 15, 2023 · 9 comments · Fixed by #1135
Closed

Tutorial: adding annotations from a JSON API for Android #811

louwers opened this issue Feb 15, 2023 · 9 comments · Fixed by #1135
Labels
android 💰 bounty S Small Bounty, USD 100 documentation Improvements or additions to documentation

Comments

@louwers
Copy link
Collaborator

louwers commented Feb 15, 2023

Create a pull requests that includes a tutorial of how to add annotations to the map on Android. This issue has an associated bounty for the documentation bounty direction.

Deliverables

@louwers louwers added documentation Improvements or additions to documentation android 💰 bounty S Small Bounty, USD 100 labels Feb 15, 2023
@louwers
Copy link
Collaborator Author

louwers commented Feb 15, 2023

@fynngodau mentioned that

Are you aware that maplibre-plugin-annotations itself contains a different sample app that makes use of its own functionality? Therefore it may not make sense to rewrite the MapLibre SDK sample app – instead we could mark deprecated features as deprecated inside the app, and add a note that developers should also look at the plugin sample app.

So the code is mostly already written. Please make use of the Annotations plugin in maplibre-plugins-android and not of the deprecated Annotations functionality in the SDK in the tutorial.

@wipfli
Copy link
Member

wipfli commented Feb 15, 2023

@louwers can you add a link to the bounty direction in maplibre/maplibre? I guess this one goes into the documentation one.

@louwers
Copy link
Collaborator Author

louwers commented Feb 15, 2023

@wipfli It's already there! 🙂

@typebrook
Copy link
Collaborator

Hi @louwers, Can I work on this?

@typebrook
Copy link
Collaborator

@louwers
By the way, this issue is only about adding tutorial in docs/mdbook/src/android/ (like what is done in #939). Any I right here?

@louwers
Copy link
Collaborator Author

louwers commented May 11, 2023

@typebrook Yes. It's all yours!

@typebrook
Copy link
Collaborator

@louwers #1135 is made, let's have further discussion there.

@louwers
Copy link
Collaborator Author

louwers commented May 18, 2023

This bounty can be paid out.

We're still figuring out how to best store the examples and if we should make the annotations available via the plugins or via the core SDK. But the acceptance criteria of this bounty have been fulfilled.

@louwers louwers closed this as completed May 18, 2023
@typebrook
Copy link
Collaborator

typebrook commented May 18, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android 💰 bounty S Small Bounty, USD 100 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants