Transform improvements #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxammann
force-pushed
the
transform-improvements
branch
from
4903814
to
c591172
Compare
maxammann
force-pushed
the
transform-improvements
branch
from
c591172
to
49eb659
Compare
maxammann
force-pushed
the
transform-improvements
branch
from
49eb659
to
a99dab1
Compare
nyurik
reviewed
May 3, 2023
# Conflicts: # maplibre/src/view_state.rs
# Conflicts: # maplibre/src/raster/upload_system.rs # maplibre/src/render/systems/tile_view_pattern_system.rs
|
soooooooo happy to see you hacking away on this :) |
Thanks! :) Yeah need to get this tidied up for EuroRust :D |
|
These apple executors are barely available :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements perspective transforms like in maplibre-gl-jsThis fundamentally reworks how the far distance plane is calculated. First I wanted to implement it like in maplibre-gl-js. Though that appraoch did not allow yaw AND pitch in both directions. It only allowed pitch in a single direction (only 90°, not the full 180°).
The new approach is dicussed here: https://gamedev.stackexchange.com/questions/207328/calculation-of-far-distance-plane-based-on-yaw-and-pitch-for-a-map-renderer
It works in all directions and should also be way faster to calculate.
This PR also fixes the amount of tiles that are whown for the current zoom. If calculates the appropriate zoom level based on the current zoom and takes into account the resolution of tiles.