Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"newStyle" not found when building Desktop CLI #662

Closed
nspringer-trimble opened this issue Apr 20, 2020 · 3 comments
Closed

"newStyle" not found when building Desktop CLI #662

nspringer-trimble opened this issue Apr 20, 2020 · 3 comments
Labels
bug
Milestone
v1.7.0

Comments

@nspringer-trimble
Copy link
Contributor

https://github.com/maputnik/editor/blob/184bfeeaf85313cfa780d653bd2dad52b4942baf/src/libs/apistore.js#L70

Should be style.replaceAccessTokens(mapStyle)
@orangemug orangemug added this to the v1.7.0 milestone Apr 21, 2020
@orangemug orangemug added the bug label Apr 21, 2020
@orangemug
Copy link
Collaborator

orangemug commented Apr 21, 2020 •
edited
Loading

Thanks @nspringer-trimble, so when I said in #606

Merging, I will give it a proper test in v1.7.0-beta3

From #606 (comment)

It turns out I forgot... Any interest in raising a PR and giving desktop a test with the fixes mentioned above?

@orangemug orangemug mentioned this issue Apr 21, 2020
Closed
@nspringer-trimble
Copy link
Contributor Author

PR sent

@orangemug
Copy link
Collaborator

Closed by #663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@orangemug @nspringer-trimble