Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge two data frames with --reconcile true leads to empty result #348

Closed
matentzn opened this issue Mar 10, 2023 · 2 comments · Fixed by #350
Closed

merge two data frames with --reconcile true leads to empty result #348

matentzn opened this issue Mar 10, 2023 · 2 comments · Fixed by #350
Assignees
Labels
bug Something isn't working

Comments

@matentzn
Copy link
Collaborator

matentzn commented Mar 10, 2023

Merging these two data frames:

# curie_map:
#   UBERON: http://purl.obolibrary.org/obo/UBERON_
#   ZFS: http://purl.obolibrary.org/obo/ZFS_
#   oio: http://www.geneontology.org/formats/oboInOwl#
#   owl: http://www.w3.org/2002/07/owl#
#   rdf: http://www.w3.org/1999/02/22-rdf-syntax-ns#
#   rdfs: http://www.w3.org/2000/01/rdf-schema#
#   semapv: https://w3id.org/semapv/
#   skos: http://www.w3.org/2004/02/skos/core#
#   sssom: https://w3id.org/sssom/
# license: https://w3id.org/sssom/license/unspecified
# mapping_set_id: https://w3id.org/sssom/mappings/72debc9d-ca69-45e8-b46d-aef8361bedf2
# object_source: ZFS
# subject_source: UBERON
subject_id	subject_label	predicate_id	object_id	mapping_justification	subject_source	object_source
UBERON:0000069	larval stage	oio:hasDbXref	ZFS:0000048	semapv:UnspecifiedMatching	UBERON	ZFS
UBERON:0000105	life cycle stage	oio:hasDbXref	ZFS:0100000	semapv:UnspecifiedMatching	UBERON	ZFS
UBERON:0000105	life cycle stage	oio:hasDbXref	ZFS:0000000	semapv:UnspecifiedMatching	UBERON	ZFS

and

# curie_map:
#   UBERON: http://purl.obolibrary.org/obo/UBERON_
#   WBls: http://purl.obolibrary.org/obo/WBls_
#   oio: http://www.geneontology.org/formats/oboInOwl#
#   owl: http://www.w3.org/2002/07/owl#
#   rdf: http://www.w3.org/1999/02/22-rdf-syntax-ns#
#   rdfs: http://www.w3.org/2000/01/rdf-schema#
#   semapv: https://w3id.org/semapv/
#   skos: http://www.w3.org/2004/02/skos/core#
#   sssom: https://w3id.org/sssom/
# license: https://w3id.org/sssom/license/unspecified
# mapping_set_id: https://w3id.org/sssom/mappings/c5e357f5-86df-4aaa-a30e-8a23ad523ab2
# object_source: WBls
# subject_source: UBERON
subject_id	subject_label	predicate_id	object_id	mapping_justification	subject_source	object_source
UBERON:0000066	fully formed stage	oio:hasDbXref	WBls:0000041	semapv:UnspecifiedMatching	UBERON	WBls
UBERON:0000068	embryo stage	oio:hasDbXref	WBls:0000003	semapv:UnspecifiedMatching	UBERON	WBls
UBERON:0000068	embryo stage	oio:hasDbXref	WBls:0000102	semapv:UnspecifiedMatching	UBERON	WBls
UBERON:0000068	embryo stage	oio:hasDbXref	WBls:0000092	semapv:UnspecifiedMatching	UBERON	WBls

results in an empty data frame.

Does not work:

sssom merge tmp/anatomy-mapping-uberon-FBbt.sssom.tsv tmp/anatomy-mapping-uberon-WBbt.sssom.tsv --reconcile true

Works:

sssom merge tmp/anatomy-mapping-uberon-FBbt.sssom.tsv tmp/anatomy-mapping-uberon-WBbt.sssom.tsv --reconcile false

We should also add a test to this end

@matentzn matentzn added the bug Something isn't working label Mar 10, 2023
@hrshdhgd
Copy link
Contributor

The 2 commands you've mentioned appear to be the same

@matentzn
Copy link
Collaborator Author

Oops, fixed. --reconcile false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants