Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: hot-reload not working #22

Closed
wants to merge 2 commits into from
Closed

Conversation

Xoronic
Copy link
Contributor

@Xoronic Xoronic commented Oct 7, 2018

No description provided.

@coveralls
Copy link

coveralls commented Oct 7, 2018

Pull Request Test Coverage Report for Build 474

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1709 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.01%) to 0.039%

Files with Coverage Reduction New Missed Lines %
src/text_cache.rs 2 0.0%
src/ui_state.rs 2 0.0%
src/cache.rs 10 0.0%
src/default_callbacks.rs 14 0.0%
src/text_layout.rs 17 0.0%
src/css.rs 75 0.0%
src/id_tree.rs 132 0.0%
target/debug/build/glium-cc3f82791ed2ac9f/out/gl_bindings.rs 193 0.0%
src/dom.rs 204 0.0%
src/ui_solver.rs 383 0.0%
Totals Coverage Status
Change from base Build 445: -0.01%
Covered Lines: 1
Relevant Lines: 2584

💛 - Coveralls

@fschutt
Copy link
Owner

fschutt commented Oct 9, 2018

I think you also need to to the other fix with the || css.hot_reload_path.is_some(). I haven't merged this yet because you said you wanted to debug this further (?).

@Xoronic
Copy link
Contributor Author

Xoronic commented Oct 9, 2018

I think you also need to to the other fix with the || css.hot_reload_path.is_some().

You are right, I will fix that.

I haven't merged this yet because you said you wanted to debug this further (?).

I think the other issues with hot-reloading are a separate bug which needs its own issue and possible PR.

@Xoronic
Copy link
Contributor Author

Xoronic commented Oct 13, 2018

I think you also need to to the other fix with the || css.hot_reload_path.is_some().

I apparently knew what you meant 4 days ago, but right now I don't get what you mean :)

Please check my latest commit and check if it matches what you have in mind.

@fschutt fschutt closed this in 9ebdd12 Oct 16, 2018
fschutt added a commit that referenced this pull request May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants