Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dragger.rs to support fast mouse traveling #40

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

pythoneer
Copy link
Contributor

Based on the suggestions made by TimTom(discord) to avoid loosing the draggable object by moving the mouse to fast by following the mouse cursor after dragging is activated by mouseup and drop it after mousedown to avoid the problems hit testing introduced in the original example.

@coveralls
Copy link

coveralls commented Nov 3, 2018

Pull Request Test Coverage Report for Build 562

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.037%

Totals Coverage Status
Change from base Build 558: 0.0%
Covered Lines: 1
Relevant Lines: 2687

💛 - Coveralls

@fschutt
Copy link
Owner

fschutt commented Nov 3, 2018

@pythoneer Thanks, but could you squash this into one commit, so it's a bit cleaner with the space removal / addition. lgtm otherwise.

Based on the suggestions made by TimTom(discord) to avoid loosing the draggable object by moving the mouse to fast by following the mouse cursor after dragging is activated by mouseup and drop it after mousedown to avoid the problems hit testing introduced in the original example.
@pythoneer
Copy link
Contributor Author

sure :)

@fschutt fschutt merged commit afd4274 into fschutt:master Nov 3, 2018
fschutt added a commit that referenced this pull request May 13, 2019
Update dragger.rs to support fast mouse traveling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants