fix 'grad' angles being unparseable #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 590
💛 - Coveralls |
fschutt
reviewed
Nov 9, 2018
fschutt
requested changes
Nov 9, 2018
|
Makes sense. Also, turns out the radian to degree conversion was wrong (multiply by pi instead of divide), so I fixed that too. |
fschutt
approved these changes
Nov 9, 2018
fschutt
added a commit
that referenced
this pull request
May 13, 2019
fix 'grad' angles being unparseable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched the order of
ends_with("rad")andends_with("grad")so that the "rad" case doesn't try to parse any "grad" angles, and added some tests for parsing both.