Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis and AppVeyor to GitHub actions #274

Merged
merged 180 commits into from Dec 28, 2021

Conversation

jbo-ads
Copy link
Member

@jbo-ads jbo-ads commented Dec 13, 2021

The changes proposed in this pull request aim at:

  • Upgrading the CI platforms on which builds and basic tests are performed prior merging, from Ubuntu 12.04, 14.04 and 16.04 to Ubuntu 18.04 and 20.04.
  • Switching CI providers from Travis and AppVeyor to GitHub Actions.

Vagrantfile also has been upgraded to Ubuntu 20.04.
Some minor bug found along the way have been fixed as well.

Comment are welcomed, in particular from Windows users.

Copy link
Member

@tbonfort tbonfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the workflow yaml itself, but all the rest looks good to me

tests/run.sh Show resolved Hide resolved
tests/setup.sh Show resolved Hide resolved
Copy link
Member

@geographika geographika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, as does the output at https://github.com/jbo-ads/mapcache/actions/runs/1573166087 (plus the new test output).
Will Appveyor be kept around for a couple of months before depracting, running in tandem with GHA?
I note the switch to PowerShell - @rouault is a big fan!

@rouault
Copy link
Contributor

rouault commented Dec 13, 2021

I note the switch to PowerShell - @rouault is a big fan!

obviously everyone has understood that this was hopefully ironic :-) I'd have gone with Bash on Windows personally but Jerome did the work already

@jbo-ads
Copy link
Member Author

jbo-ads commented Dec 13, 2021

@geographika - This pull request adds GitHub Actions without suppressing AppVeyor and Travis CI. We can let run both during a few months and pull the trigger when the new approach is validated.
Powershell is not a choice of mine (see the number of commits before reaching a good state...) @rouault : My first attempt was with bash, until I realized that handling windows filepaths stored in default variables such as ${{github.workspace}} would have been a biggest nightmare than learning Powershell basics. Si fueris Romae, Romano vivito more

@jbo-ads jbo-ads merged commit 483aaf8 into MapServer:main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants