Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes - Fix all '...' problems in file #50

Open
mkrumpholz opened this issue Jun 30, 2020 · 2 comments
Open

Quick fixes - Fix all '...' problems in file #50

mkrumpholz opened this issue Jun 30, 2020 · 2 comments

Comments

@mkrumpholz
Copy link

mkrumpholz commented Jun 30, 2020

With the quick fix there comes the "Fix all 'Unmapped target properties' problems in file" option. But this only fixes the selected target property and not all as it should. Also it is not clear if fix all means add all or ignore all properties.

  1. the fix all should go through the list of all similar problems
  2. all similar should make a difference between add and ignore, depending on what menu entry was selected

I recognized that there is an "Ignore all unmapped target properties". That helps on the first level in the menu but the "Fix all..." in the submenu is also a common usage in IntelliJ IDEA. At least having the same for add would be a quick win while completing the implentation to Fix all later on.

@filiphr
Copy link
Member

filiphr commented Jul 4, 2020

Thanks for the feedback @mkrumpholz.

The problem with the "Fix all..." is that it doesn't apply the selected quick fix as a solution for the fix all. Not sure how the "Fix all" works. The problem here is that there are 2 completely different possibilities for fixing all. It is either ignoring or adding a source and not sure whether you can influence the "Fix all...".

If you know how to do it then please share the info or provide a PR so we can improve this.

@mkrumpholz
Copy link
Author

Isn't there any context, meta info, properties or some other information about the selected entry on the first level in the quick fix menu? Some kind of parent or so? The it would be possible to differ between ignore and add.

I'm probably on the same level or less in plugin development like you: searching plugin dev docs or jetbrains forums on how to implement the required solution, maybe even debugging from the last known code deeper into IDEA's code. 😃 As i didn't implement quick fixes i can't provide a solution, just knowing and using this quite often as a developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants