Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapsui fetcher goes into a loop when tiles are missing #52

Closed
pauldendulk opened this issue Aug 18, 2015 · 2 comments
Closed

Mapsui fetcher goes into a loop when tiles are missing #52

pauldendulk opened this issue Aug 18, 2015 · 2 comments
Assignees
@pauldendulk
Labels
bug 🐛
Milestone
1.0

Comments

@pauldendulk
Copy link
Member

reported by @kwesolowski
BruTile/BruTile#23
@pauldendulk pauldendulk self-assigned this Mar 9, 2016
@pauldendulk
Copy link
Member Author

High priority

@pauldendulk pauldendulk added this to the 1.0 milestone Nov 1, 2016
@drwatson1 drwatson1 mentioned this issue Nov 18, 2016
Closed
pauldendulk added a commit that referenced this issue Nov 26, 2016
@pauldendulk
Adding tilefetcher tests for sources with null and exception response…
b70e3e0 
…s for #52
@pauldendulk
Copy link
Member Author

Added some unit tests. The fetcher does not go into a loop.

Room for improvement: When null is returned the fetcher will try again after viewport changes. The cache could store something indicating the tile is not available. This is something that should be tested carefully in various scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pauldendulk pauldendulk

Labels
bug 🐛
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@pauldendulk