Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Filter Editing #38

Closed
lukasmartinelli opened this issue Dec 29, 2016 · 8 comments
Closed

Better Filter Editing #38

lukasmartinelli opened this issue Dec 29, 2016 · 8 comments

Comments

@lukasmartinelli
Copy link
Collaborator

The current filter component only allows editing (not adding) and also does not support deeply nested filters.

screenshot from 2016-12-29 17-41-18

@lukasmartinelli
Copy link
Collaborator Author

Is that the biggest missing feature so far for you @muesliq?
Apart from the bugs that still need to be ironed out (source adding is quite buggy).

@muesliq
Copy link
Collaborator

muesliq commented Jan 4, 2017

I would say so @lukasmartinelli, yes. However I'm not sure if all bugs are reported yet. Will check.

@muesliq
Copy link
Collaborator

muesliq commented Jan 4, 2017

Biggest missing feature apart from this is #52.

@lukasmartinelli
Copy link
Collaborator Author

screenshot from 2017-01-10 09-54-17

@muesliq
Copy link
Collaborator

muesliq commented Jan 10, 2017

I'm not convinced that that's the best place to put the button. Best practice to extend a list by another element is in line with that list. (Below or above.) Now it's squashed between two elements that stand in no direct connection to that list.

Also the button styling is very similar to input fields. Doesn't look clickable.

I'd suggest something like this (also for Stops):

screen shot 2017-01-10 at 14 29 46

@lukasmartinelli
Copy link
Collaborator Author

Yes putting it below on the right is one option I haven't tried. Thanks.

@muesliq
Copy link
Collaborator

muesliq commented Jan 10, 2017

Yep, the position is the important thing. A button there would probably do, too.

@lukasmartinelli
Copy link
Collaborator Author

Moved it. I think I really need to expose the CSS so it is easy to hack and iterate.
Important part is that it is functional now.

Moved the button to the right bottom.
Perhaps the delete/zoom funcs should all be on the right to.

Will track further UX things in another ticket.

screenshot from 2017-01-10 18-59-48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants