Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison swiper #4

Closed
stirringhalo opened this issue Sep 23, 2016 · 2 comments
Closed

Comparison swiper #4

stirringhalo opened this issue Sep 23, 2016 · 2 comments

Comments

@stirringhalo
Copy link

Great effort, glad to see this! Styling by hand was always the pain...

I'd love to see a comparison wiper like http://45.56.99.211/. I used the editor here https://github.com/erikandre/mapbox-gl-style-editor with some tweaks here https://github.com/stirringhalo/mapbox-gl-style-editor to get the side-swipe.

@lukasmartinelli
Copy link
Collaborator

I have difficulty to imagine where this might fit?

One could compare revisions of style with each other. But I only save the latest version of a style to keep it simple (all currently edited revisions are in memory though for undo/redo) support.

I am probably not going to implement this because the editor has no support for having two styles at the same time and there is also no notion of having different versions of the same style around since there is no "Publish" step or so.

@muesliq
Copy link
Collaborator

muesliq commented Jan 4, 2017

I really like the idea. My style creation workflow often involves comparison with other styles, not necessarily Mapbox GL styles but also raster tile styles.

While such a swiper would be really useful, it would have to be fast. My experience with GL swipers with vector / raster mixes is that they are very laggy. I prefer using different browser windows that I have 'synchronize' by hand to a laggy swiper.

jsanz pushed a commit to jsanz/ems-basemap-editor that referenced this issue Jul 30, 2020
nyurik pushed a commit that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants