Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from react-autocomplete to alternative #611

Open
orangemug opened this issue Jan 30, 2020 · 0 comments
Open

Switch from react-autocomplete to alternative #611

orangemug opened this issue Jan 30, 2020 · 0 comments
Labels
good first issue help wanted maintenance

Comments

@orangemug
Copy link
Collaborator

'react-autocomplete' (https://github.com/reactjs/react-autocomplete) is no longer maintained and causing warnings

react-dom.development.js:12357 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
  • Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run npx react-codemod rename-unsafe-lifecycles in your project source folder.

Please update the following components: Autocomplete

Tasks

  • Find good currently maintained alternative and migrate to that library. Note it must be WAI-ARIA compliant

To investigate
@HarelM HarelM mentioned this issue Mar 21, 2024
Merged
5 tasks
HarelM added a commit that referenced this issue Mar 21, 2024
@HarelM
Update React to version 18 and other deps (#890)
ff15b77 
This PR aims at updating some packages.
I'll keep this in draft until I'll be more happy with the results.
Current setup seems to work, I'll let the CI run and see how bad this
is.
Packages that needs to be updated/replaces:
- [x] ~autocompete - The only warning left in the console is related to
the autocomplete, which probably needs to be updated since it's a
package that wasn't updated in the last 6 years.~ #611
- [x] ~Codemirror is also something that will need an update, but it
looks too complicated at this point in time, so let's see how this
goes.~ #891
- [ ] react-color
- [x] ~react-aria-menubutton~ #846
- [ ] Others?

Most of the changes here are related to types, which is good.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orangemug